Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated alternative Connector constructor argument order #315

Merged
merged 1 commit into from
May 31, 2024

Conversation

clue
Copy link
Member

@clue clue commented May 22, 2024

This simple changeset drops the deprecated alternative Connector constructor argument order. As of v1.9.0, we recommend using the new Connector signature with the optional $context as first argument and optional $loop as second argument, so upgrading should be straightforward for most use cases:

// unchanged
$connector = new React\Socket\Connector();

// old (no longer supported)
$connector = new React\Socket\Connector(null, $context);
$connector = new React\Socket\Connector($loop, $context);

// new (already supported since v1.9.0)
$connector = new React\Socket\Connector($context);
$connector = new React\Socket\Connector($context, $loop);

The original deprecation message has been in place for a couple of years already, so this should be relatively safe to apply.

Note that this temporarily introduces an implicitly nullable type that should be removed in a follow-up as discussed in reactphp/promise#260. Additionally, a follow-up PR should drop the entire $loop argument as discussed in #312.

Builds on top of #264 and #314.

@clue clue added the BC break label May 22, 2024
@clue clue added this to the v3.0.0 milestone May 22, 2024
@clue clue requested review from WyriHaximus and SimonFrings May 22, 2024 19:51
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's get this shipped 👍

@WyriHaximus WyriHaximus merged commit a2b4fe1 into reactphp:3.x May 31, 2024
28 checks passed
@clue clue deleted the drop-connector-alternative branch May 31, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants